Fix missing type definition #1514

m208 · 2024-09-15T19:47:30Z

Fixed missing type definition for the "name" property of the Action object, which is used as the class name for the button.

Source:

leaflet-geoman/src/js/Toolbar/L.Controls.js

Lines 163 to 176 in 9f6aac7

    
           const name = typeof _action === 'string' ? _action : _action.name; 
        
           let action; 
        
           if (actions[name]) { 
        
             action = actions[name]; 
        
           } else if (_action.text) { 
        
             action = _action; 
        
           } else { 
        
             return; 
        
           } 
        
           const actionNode = L.DomUtil.create( 
        
             'a', 
        
             `leaflet-pm-action ${pos} action-${name}`, 
        
             actionContainer 
        
           );

TS error:

Falke-Design

Thank you for fixing this.

fix missing type definition

269d77a

Falke-Design approved these changes Sep 15, 2024

View reviewed changes

Falke-Design merged commit c8961ef into geoman-io:develop Sep 15, 2024
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix missing type definition #1514

Fix missing type definition #1514

m208 commented Sep 15, 2024

Falke-Design left a comment

	const name = typeof _action === 'string' ? _action : _action.name;
	let action;
	if (actions[name]) {
	action = actions[name];
	} else if (_action.text) {
	action = _action;
	} else {
	return;
	}
	const actionNode = L.DomUtil.create(
	'a',
	`leaflet-pm-action ${pos} action-${name}`,
	actionContainer
	);

Fix missing type definition #1514

Fix missing type definition #1514

Conversation

m208 commented Sep 15, 2024

Falke-Design left a comment

Choose a reason for hiding this comment